From 777ed5c746836380a0e24e331c2a542589125443 Mon Sep 17 00:00:00 2001
From: Buddhism8003 <lindemeier@purelymail.com>
Date: Fri, 18 Oct 2024 15:46:12 +0200
Subject: [PATCH] support null columns parameter

---
 src/HtmlConverter.php       |  3 +++
 tests/HtmlConverterTest.php | 13 +++++++++++--
 2 files changed, 14 insertions(+), 2 deletions(-)

diff --git a/src/HtmlConverter.php b/src/HtmlConverter.php
index 6e4decd..8f9602a 100644
--- a/src/HtmlConverter.php
+++ b/src/HtmlConverter.php
@@ -38,6 +38,9 @@ class HtmlConverter {
             }
             $this->columns = $tmpColumns;
         }
+        else{
+            $this->columns = ConverterHelpers::RangeToColumnArray('A-'.$worksheet->getHighestDataColumn());
+        }
         $this->scale = $scale;
         $this->worksheet = $worksheet;
         $this->html = '';
diff --git a/tests/HtmlConverterTest.php b/tests/HtmlConverterTest.php
index f87a01a..09d5c49 100644
--- a/tests/HtmlConverterTest.php
+++ b/tests/HtmlConverterTest.php
@@ -1,5 +1,4 @@
 <?php
-use CSO\Excel2Html\ConverterHelpers;
 use CSO\Excel2Html\Exceptions\SheetNotFoudException;
 use PHPUnit\Framework\TestCase;
 use CSO\Excel2Html\HtmlConverter;
@@ -67,7 +66,17 @@ final class HtmlConverterTest extends TestCase{
             'tests/assets/test.xlsx', 
             styleOption: StyleOptions::WITH_COLUMN_WIDTH | StyleOptions::COLUMN_WIDTH_PROPORTIONAL, 
             worksheetName:'TestTable', 
-            columns:['A', 'B-F'],
+            columns:['A', 'B-E', 'F'],
+            scale: 1.1);
+        $res = $conv->getHtml();
+        $expected = file_get_contents('tests/assets/results/testProp.html');
+        $this->assertSame($expected, $res);
+    }
+    public function testHtmlPropIsSameWithoutColumns(): void{
+        $conv = HtmlConverter::fromFilepath(
+            'tests/assets/test.xlsx', 
+            styleOption: StyleOptions::WITH_COLUMN_WIDTH | StyleOptions::COLUMN_WIDTH_PROPORTIONAL, 
+            worksheetName:'TestTable', 
             scale: 1.1);
         $res = $conv->getHtml();
         $expected = file_get_contents('tests/assets/results/testProp.html');